[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 14/25] hw/sd: sd.h: Cosmetic change of using spaces
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 14/25] hw/sd: sd.h: Cosmetic change of using spaces |
Date: |
Sun, 24 Jan 2021 18:43:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/23/21 11:40 AM, Bin Meng wrote:
> From: Bin Meng <bin.meng@windriver.com>
>
> QEMU coding convention prefers spaces over tabs.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
>
> ---
>
> Changes in v2:
> - Correct the "coding" typo in the commit message
>
> include/hw/sd/sd.h | 42 +++++++++++++++++++++---------------------
> 1 file changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/include/hw/sd/sd.h b/include/hw/sd/sd.h
> index 59d108d453..05ef9b73e5 100644
> --- a/include/hw/sd/sd.h
> +++ b/include/hw/sd/sd.h
> @@ -33,27 +33,27 @@
> #include "hw/qdev-core.h"
> #include "qom/object.h"
>
> -#define OUT_OF_RANGE (1 << 31)
> -#define ADDRESS_ERROR (1 << 30)
> -#define BLOCK_LEN_ERROR (1 << 29)
> -#define ERASE_SEQ_ERROR (1 << 28)
> -#define ERASE_PARAM (1 << 27)
> -#define WP_VIOLATION (1 << 26)
> -#define CARD_IS_LOCKED (1 << 25)
> -#define LOCK_UNLOCK_FAILED (1 << 24)
> -#define COM_CRC_ERROR (1 << 23)
> -#define ILLEGAL_COMMAND (1 << 22)
> -#define CARD_ECC_FAILED (1 << 21)
> -#define CC_ERROR (1 << 20)
> -#define SD_ERROR (1 << 19)
> -#define CID_CSD_OVERWRITE (1 << 16)
> -#define WP_ERASE_SKIP (1 << 15)
> -#define CARD_ECC_DISABLED (1 << 14)
> -#define ERASE_RESET (1 << 13)
> -#define CURRENT_STATE (7 << 9)
> -#define READY_FOR_DATA (1 << 8)
> -#define APP_CMD (1 << 5)
> -#define AKE_SEQ_ERROR (1 << 3)
> +#define OUT_OF_RANGE (1 << 31)
> +#define ADDRESS_ERROR (1 << 30)
> +#define BLOCK_LEN_ERROR (1 << 29)
> +#define ERASE_SEQ_ERROR (1 << 28)
> +#define ERASE_PARAM (1 << 27)
> +#define WP_VIOLATION (1 << 26)
> +#define CARD_IS_LOCKED (1 << 25)
> +#define LOCK_UNLOCK_FAILED (1 << 24)
> +#define COM_CRC_ERROR (1 << 23)
> +#define ILLEGAL_COMMAND (1 << 22)
> +#define CARD_ECC_FAILED (1 << 21)
> +#define CC_ERROR (1 << 20)
> +#define SD_ERROR (1 << 19)
> +#define CID_CSD_OVERWRITE (1 << 16)
> +#define WP_ERASE_SKIP (1 << 15)
> +#define CARD_ECC_DISABLED (1 << 14)
> +#define ERASE_RESET (1 << 13)
> +#define CURRENT_STATE (7 << 9)
> +#define READY_FOR_DATA (1 << 8)
> +#define APP_CMD (1 << 5)
> +#define AKE_SEQ_ERROR (1 << 3)
The plan was to use the REGISTERFIELD definitions
we already have in sd.c and simply remove these:
FIELD(CSR, AKE_SEQ_ERROR, 3, 1)
FIELD(CSR, APP_CMD, 5, 1)
FIELD(CSR, FX_EVENT, 6, 1)
FIELD(CSR, READY_FOR_DATA, 8, 1)
FIELD(CSR, CURRENT_STATE, 9, 4)
FIELD(CSR, ERASE_RESET, 13, 1)
FIELD(CSR, CARD_ECC_DISABLED, 14, 1)
FIELD(CSR, WP_ERASE_SKIP, 15, 1)
FIELD(CSR, CSD_OVERWRITE, 16, 1)
FIELD(CSR, DEFERRED_RESPONSE, 17, 1)
FIELD(CSR, ERROR, 19, 1)
FIELD(CSR, CC_ERROR, 20, 1)
FIELD(CSR, CARD_ECC_FAILED, 21, 1)
FIELD(CSR, ILLEGAL_COMMAND, 22, 1)
FIELD(CSR, COM_CRC_ERROR, 23, 1)
FIELD(CSR, LOCK_UNLOCK_FAILED, 24, 1)
FIELD(CSR, CARD_IS_LOCKED, 25, 1)
FIELD(CSR, WP_VIOLATION, 26, 1)
FIELD(CSR, ERASE_PARAM, 27, 1)
FIELD(CSR, ERASE_SEQ_ERROR, 28, 1)
FIELD(CSR, BLOCK_LEN_ERROR, 29, 1)
FIELD(CSR, ADDRESS_ERROR, 30, 1)
FIELD(CSR, OUT_OF_RANGE, 31, 1)
Anyway, we never got there...
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- Re: [PATCH v2 18/25] hw/sd: ssi-sd: Bump up version ids of VMStateDescription, (continued)
[PATCH v2 17/25] hw/sd: ssi-sd: Support multiple block write, Bin Meng, 2021/01/23
[PATCH v2 11/25] hw/sd: ssi-sd: Use macros for the dummy value and tokens in the transfer, Bin Meng, 2021/01/23
[PATCH v2 13/25] hw/sd: sd: Allow single/multiple block write for SPI mode, Bin Meng, 2021/01/23
[PATCH v2 14/25] hw/sd: sd.h: Cosmetic change of using spaces, Bin Meng, 2021/01/23
- Re: [PATCH v2 14/25] hw/sd: sd.h: Cosmetic change of using spaces,
Philippe Mathieu-Daudé <=
[PATCH v2 15/25] hw/sd: Introduce receive_ready() callback, Bin Meng, 2021/01/23
[PATCH v2 16/25] hw/sd: ssi-sd: Support single block write, Bin Meng, 2021/01/23
[PATCH v2 19/25] hw/ssi: Add SiFive SPI controller support, Bin Meng, 2021/01/23
[PATCH v2 23/25] docs/system: Sort targets in alphabetical order, Bin Meng, 2021/01/23
[PATCH v2 25/25] docs/system: riscv: Add documentation for sifive_u machine, Bin Meng, 2021/01/23
[PATCH v2 20/25] hw/riscv: sifive_u: Add QSPI0 controller and connect a flash, Bin Meng, 2021/01/23
[PATCH v2 22/25] hw/riscv: sifive_u: Change SIFIVE_U_GEM_IRQ to decimal value, Bin Meng, 2021/01/23
[PATCH v2 21/25] hw/riscv: sifive_u: Add QSPI2 controller and connect an SD card, Bin Meng, 2021/01/23
[PATCH v2 24/25] docs/system: Add RISC-V documentation, Bin Meng, 2021/01/23
Re: [PATCH v2 00/25] hw/riscv: sifive_u: Add missing SPI support, Philippe Mathieu-Daudé, 2021/01/24