Re: [PATCH v1 2/5] target/riscv: Use the RiscVException enum for CSR pre

qemu-riscv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 2/5] target/riscv: Use the RiscVException enum for CSR pre

From:	Richard Henderson
Subject:	Re: [PATCH v1 2/5] target/riscv: Use the RiscVException enum for CSR predicates
Date:	Wed, 17 Mar 2021 13:44:03 -0600
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 3/17/21 11:39 AM, Alistair Francis wrote:

@@ -1312,8 +1320,8 @@ int riscv_csrrw(CPURISCVState *env, int csrno, 
target_ulong *ret_value,
          return -RISCV_EXCP_ILLEGAL_INST;
      }
      ret = csr_ops[csrno].predicate(env, csrno);
-    if (ret < 0) {
-        return ret;
+    if (ret > 0) {
+        return -ret;
      }


I think you want

  if (ret != RISCV_EXCP_NONE) {
     return -ret;
  }

here. But of course this outer interface is still confused until patches 4+5.So perhaps it doesn't matter.

r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v1 0/5] RISC-V: Convert the CSR access functions to use, Alistair Francis, 2021/03/17
- [PATCH v1 1/5] target/riscv: Convert the RISC-V exceptions to an enum, Alistair Francis, 2021/03/17
  - Re: [PATCH v1 1/5] target/riscv: Convert the RISC-V exceptions to an enum, Bin Meng, 2021/03/17
    - Re: [PATCH v1 1/5] target/riscv: Convert the RISC-V exceptions to an enum, Alistair Francis, 2021/03/19
- [PATCH v1 2/5] target/riscv: Use the RiscVException enum for CSR predicates, Alistair Francis, 2021/03/17
  - Re: [PATCH v1 2/5] target/riscv: Use the RiscVException enum for CSR predicates, Richard Henderson <=
    - Re: [PATCH v1 2/5] target/riscv: Use the RiscVException enum for CSR predicates, Alistair Francis, 2021/03/19
- [PATCH v1 3/5] target/riscv: Fix 32-bit HS mode access permissions, Alistair Francis, 2021/03/17
- [PATCH v1 4/5] target/riscv: Use the RiscVException enum for CSR operations, Alistair Francis, 2021/03/17
- [PATCH v1 5/5] target/riscv: Use RiscVException enum for CSR access, Alistair Francis, 2021/03/17
  - Re: [PATCH v1 5/5] target/riscv: Use RiscVException enum for CSR access, Richard Henderson, 2021/03/18
    - Re: [PATCH v1 5/5] target/riscv: Use RiscVException enum for CSR access, Alistair Francis, 2021/03/19

Prev by Date: Re: [PATCH] target/riscv: Add proper two-stage lookup exception detection
Next by Date: Re: [PATCH 06/38] target/riscv: SIMD 16-bit Shift Instructions
Previous by thread: [PATCH v1 2/5] target/riscv: Use the RiscVException enum for CSR predicates
Next by thread: Re: [PATCH v1 2/5] target/riscv: Use the RiscVException enum for CSR predicates
Index(es):
- Date
- Thread