[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 07/11] hw/riscv: write bootargs 'chosen' FDT after riscv_l

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v4 07/11] hw/riscv: write bootargs 'chosen' FDT after riscv_load_kernel()
Date: Fri, 30 Dec 2022 13:53:31 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1

On 29/12/22 19:11, Daniel Henrique Barboza wrote:
The sifive_u, spike and virt machines are writing the 'bootargs' FDT
node during their respective create_fdt().

Given that bootargs is written only when '-append' is used, and this
option is only allowed with the '-kernel' option, which in turn is
already being check before executing riscv_load_kernel(), write
'bootargs' in the same code path as riscv_load_kernel().

Cc: Palmer Dabbelt <palmer@dabbelt.com>
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Bin Meng <bmeng@tinylab.org>
  hw/riscv/sifive_u.c | 11 +++++------
  hw/riscv/spike.c    |  9 +++++----
  hw/riscv/virt.c     | 11 +++++------
  3 files changed, 15 insertions(+), 16 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]