ratpoison-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[RP] New windows appearing in empty frames. Intended?


From: Bernhard R. Link
Subject: [RP] New windows appearing in empty frames. Intended?
Date: Fri Mar 26 08:34:04 2004
User-agent: Mutt/1.3.28i

I don't know if it is a bug or a feature. When a new window opens
up and there is a empty frame around, it opens up there, changing
which frame is active. While this can sometimes be usefull and I
first considered it a feature, its annoying with notification windows,
that appear for a few seconds and vanis then, as they either drag
windows without frame in a frame they might not fit or leave with
a blank frame activated.

Looking at the code why this happens at all, it looks more like
this is not an intended behaviour, as the fix is the following:

Index: split.c
===================================================================
RCS file: /cvsroot/ratpoison/ratpoison/src/split.c,v
retrieving revision 1.51
diff -U6 -r1.51 split.c
--- split.c     27 Feb 2004 09:29:25 -0000      1.51
+++ split.c     26 Mar 2004 14:35:50 -0000
@@ -222,12 +222,18 @@
 rp_frame *
 find_windows_frame (rp_window *win)
 {
   rp_screen *s;
   rp_frame *cur;
 
+  /* Without this a newly poped up window will end up in
+   * a free frame if there is any instead of the current frame,
+   * and then pull another window in there if it vanishes again... */
+  if (win->number == EMPTY)
+    return NULL;
+
   s = win->scr;
 
   list_for_each_entry (cur, &s->frames, node)
     {
       if (cur->win_number == win->number) return cur;
     }

So is this feature intended or not?

Hochachtungsvoll,
        Bernhard R. Link



reply via email to

[Prev in Thread] Current Thread [Next in Thread]