Re: [Savannah-hackers] sshd crashed

[Niels Möller]

Loic Dachary <address@hidden> writes:

>       I hope Niels will be able to provide us a patch to fix the
> utf8 exception problem. lsh crashed again on the very same problem.
> The running lsh on subversions is 1.2.1 that was recompiled in
> /usr/local/src/lsh-1.2.1 as described in 
> http://savannah.gnu.org/savannah.html#lsh%20and%20ssh

I've not yet had the time to reproduce and analyze the bug in detail,
but you could try the patch below. It is relative to 1.2.2, and it
should get lshd to drop the connection rather than crash.

Regards,
/Niels

diff -u -r1.31 server_userauth.c
--- server_userauth.c   2001/02/25 22:38:20     1.31
+++ server_userauth.c   2001/06/25 12:26:57
@@ -343,9 +343,12 @@
   connection->dispatch[SSH_MSG_USERAUTH_REQUEST] =
     make_userauth_handler(self->methods, self->services,
                          c, e,
+                         /* Use the connection's exception handler as
+                          * parent, in order to get reasonable
+                          * handling of EXC_PROTOCOL. */
                           make_exc_userauth_handler(connection,
                                                     self->advertised_methods,
-                                                    AUTH_ATTEMPTS, e,
+                                                    AUTH_ATTEMPTS, 
connection->e,
                                                     HANDLER_CONTEXT));
 }