Re: [Sks-devel] Re: incremental dumps

[Peter Palfrader]

On Thu, 18 Mar 2004, Yaron M. Minsky wrote:

> A version of this patch is now in CVS.  Take a look at it and tell me what
> you think.

Looking good.  How efficient is using Set.remove compared to a miss when
searching keys by hash?

Also, there's no need to flush stdout in every iteration.  If it was in
my patch it was part of some debugging/status output I had.


? ChangeLog
Index: incdump.ml
===================================================================
RCS file: /cvsroot/sks/sks/incdump.ml,v
retrieving revision 1.1
diff -u -r1.1 incdump.ml
--- incdump.ml  18 Mar 2004 02:56:25 -0000      1.1
+++ incdump.ml  18 Mar 2004 12:52:13 -0000
@@ -53,7 +53,6 @@
       Set.iter newkeys 
        ~f:(fun hash ->
              try
-               flush stdout;
                let keystring = Keydb.get_keystring_by_hash hash in
                output_string file keystring;
              with

Peter
-- 
 PGP signed and encrypted  |  .''`.  ** Debian GNU/Linux **
    messages preferred.    | : :' :      The  universal
                           | `. `'      Operating System
 http://www.palfrader.org/ |   `-    http://www.debian.org/

signature.asc
Description: Digital signature