Re: [Sks-devel] Re: incremental dumps

[Yaron Minsky]

Peter Palfrader said:
> On Thu, 18 Mar 2004, Yaron M. Minsky wrote:
>
>> A version of this patch is now in CVS.  Take a look at it and tell me
>> what
>> you think.
>
> Looking good.  How efficient is using Set.remove compared to a miss when
> searching keys by hash?

I haven't benchmarked it, but I would expect Set.remove to be an order of
magnitude cheaper.  Probably more.

> Also, there's no need to flush stdout in every iteration.  If it was in
> my patch it was part of some debugging/status output I had.

Fair enough.

y

>
>
> ? ChangeLog
> Index: incdump.ml
> ==================================================================RCS
> file: /cvsroot/sks/sks/incdump.ml,v
> retrieving revision 1.1
> diff -u -r1.1 incdump.ml
> --- incdump.ml        18 Mar 2004 02:56:25 -0000      1.1
> +++ incdump.ml        18 Mar 2004 12:52:13 -0000
> @@ -53,7 +53,6 @@
>        Set.iter newkeys
>       ~f:(fun hash ->
>             try
> -             flush stdout;
>               let keystring = Keydb.get_keystring_by_hash hash in
>               output_string file keystring;
>             with
>
> Peter
> --
>  PGP signed and encrypted  |  .''`.  ** Debian GNU/Linux **
>     messages preferred.    | : :' :      The  universal
>                            | `. `'      Operating System
>  http://www.palfrader.org/ |   `-    http://www.debian.org/
>


|--------/            Yaron M. Minsky              \--------|
|--------\ http://www.cs.cornell.edu/home/yminsky/ /--------|

Open PGP --- KeyID B1FFD916
Fingerprint: 5BF6 83E1 0CE3 1043 95D8 F8D5 9F12 B3A9 B1FF D916