[Opentts-dev] merging opentts and speechd was Re: Fwd: Re: OpenTTS 0.1 released.

[William Hubbs]

Hello Hynek,

On Thu, Jun 10, 2010 at 08:56:50AM -0500, Christopher Brannon wrote:
> Hynek Hanke wrote:
> >      3) The patch you mention send to the list is totally broken. It just
> >      plain removes part of the code which was important. If we would apply
> >      that, we would break commands like "spd-say -S" or "spd-say -C".
> 
> Yes, my patch is broken.
> We should be using the external variable optind to find the first non-option
> argument, rather than using argc.  The getopt_long function sets that
> variable.  Also, -C and -S should be usable without a message.

This is a good example of what would make the community feel more
welcome in working with Brailcom, imho, code review.

When patches are posted to the speechd list, can you respond to them
like this and tell us if you accept the patches or not, and if not why
not?

I know that if I post a patch and get a message that says what is wrong
with it, I would go fix it.

William

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20100610/75d58c59/attachment.pgp>