speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Add i18n utilities to common library


From: Rui Batista
Subject: [PATCH] Add i18n utilities to common library
Date: Wed, 06 Oct 2010 01:05:27 +0100

Hi,
Ter, 2010-10-05 ?s 17:59 -0500, William Hubbs escreveu:
> Hi Rui,
> 
> On Tue, Oct 05, 2010 at 09:44:31PM +0200, Andrei Kholodnyi wrote:
> > > setlocale doesn't return nothing we can check for errors...
> > > The other two return NULL on out of memory. In this case what should we
> > > do? Abort?
> > 
> > I think just return an error e.g. -1 and let caller decide what to do.
> 
>  Most of our other out of memory situations are handled by glib's
>  allocation routines which abort in that situation, so, for consistency,
>  I would vote for aborting.  That also means you don't have to change
>  your functions to return values.
> 
I can make it either way: aborting or returning status code. But I do
also vote for aborting. Should I repost the patch with abort calls?

Rui Batista


> William





reply via email to

[Prev in Thread] Current Thread [Next in Thread]