[PATCH] Add i18n utilities to common library

[William Hubbs]

On Wed, Oct 06, 2010 at 01:05:27AM +0100, Rui Batista wrote:
> Hi,
> Ter, 2010-10-05 ??s 17:59 -0500, William Hubbs escreveu:
> > Hi Rui,
> > 
> > On Tue, Oct 05, 2010 at 09:44:31PM +0200, Andrei Kholodnyi wrote:
> > > > setlocale doesn't return nothing we can check for errors...
> > > > The other two return NULL on out of memory. In this case what should we
> > > > do? Abort?
> > > 
> > > I think just return an error e.g. -1 and let caller decide what to do.
> > 
> >  Most of our other out of memory situations are handled by glib's
> >  allocation routines which abort in that situation, so, for consistency,
> >  I would vote for aborting.  That also means you don't have to change
> >  your functions to return values.
> > 
> I can make it either way: aborting or returning status code. But I do
> also vote for aborting. Should I repost the patch with abort calls?

Sure,, go ahead and do that.

Also, I don't think you need to touch configure.ac.  I think that
localedir is already defined, so you don't need to define it or use
AC_SUBST() for it.

Thanks,

William

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20101005/460a713c/attachment.pgp>