[PATCH] Add i18n utilities to common library

[Andrei Kholodnyi]

Hi Rui,

nice to see patches coming from you again, here are my comments

> +#ifndef I18N_H
> +#define I18N_H
> +#include <glib/gi18n.h>

not clear why do you need glib header here.
you have only void init_i18n (void) declaration.

> +void init_i18n(void);

it is better to have it returning status instead of void.
there are three functions called inside, all of them returning something.

> +void init_i18n(void)
> +{
> + ? ? ? setlocale(LC_ALL, "");
> + ? ? ? bindtextdomain(GETTEXT_PACKAGE, LOCALEDIR);
> + ? ? ? textdomain(GETTEXT_PACKAGE);
> +}

shouldn't it be also
#include <libintl.h>

for bindtextdomain and textdomain?

Thanks,
Andrei.