Re: [Tsp-devel] [PATCH] Fix compilation warnings

[Frederik Deweerdt]

On Fri, Nov 09, 2007 at 11:39:14PM +0100, Stephane GALLES wrote:
> Frederik Deweerdt wrote:
> > On Fri, Nov 09, 2007 at 07:48:00PM +0100, Robert de Vries wrote:
> >> On Thursday 08 November 2007 02:55:32 pm Eric Noulard wrote:
> >>> 2007/11/6, Robert de Vries <address@hidden>:
> >>>> This is the only fix that might not work as it seems that the free
> >>>> function was only programmed and never actually called since version
> >>>> 1.1 of that file.
> >>> All those files "belongs" to Stephane ("Euskadi")
> >>> I think you fixes is OK and I think you should commit thoses
> >>> unless Stephane steps in and tell us why it may be dangerous
> >>> to do so.
> >> I didn't hear anything so I checked the patch in. It always possible to 
> >> revert 
> >> the change.
> > Cool! Compiles fine here. BTW, I turned -Wall on and gcc didn't complain
> > either.
> > 
> 
> Very nice job !
> 
> Still, since the CruiseControl continuous build on my i386/32bits
> desktop builds TSP in vanilla mode, and then in XMLRPC mode, I see some
> more warnings in the XMLRPC code that does not show up in the normal
> mode (I may have a look to these XMLRPC warnings whenever I have time)
I've fixed them, thanks :)

Frederik