Re: [Tsp-devel] [PATCH] Fix compilation warnings

[Eric Noulard]

2007/11/6, Robert de Vries <address@hidden>:
> Hi all,
>
> I got a bit annoyed by all the compiler warnings of tsp so I sat down
> and fixed most of them.

I may understand that.
I did began that same work some times ago and I did gave
up because when reading I was wanting to rewrite 50% of the code :=)

> I did not fix the compiler warnings on the generated rpc xdr code.
> I did not fix one cast from a pointer to an int in
> tsp/src/core/ctrl/tsp_group_algo.c:335: warning: assignment makes
> pointer from integer without a cast

Ok will have a look at this.

>
> All the other warnings I fixed.
> Most of them required a couple of casts from char * to xmlChar * or vice 
> versa.
[...]
> This is the only fix that might not work as it seems that the free
> function was only programmed and never actually called since version
> 1.1 of that file.

All those files "belongs" to Stephane ("Euskadi")
I think you fixes is OK and I think you should commit thoses
unless Stephane steps in and tell us why it may be dangerous
to do so.

> It would be nice if an actual cmake user would remove the -W -Wall
> flag for the compilation of the generated code. This would only leave
> one warning message. (for erk)

I did fix this using CMake
SET_SOURCE_FILES_PROPERTIES command
from within tsp/make/FindONCRPC.cmake

in fact the code was already there but I was doing
weird check about CMake version being used as if
the command wasn't supported by all CMake version.

After checking this it seems that it is supported at least
since CMake 2.2.3 so... I removed the CMake version check.

You should update and re-run CMake.
Then with this+your patch it remains only 1 warning
in tsp_group_algo.c:335.

Thank you Robert.
-- 
Erk