Re: console-ncurses segv

[Marcus Brinkmann]

On Thu, Aug 29, 2002 at 12:32:47AM -0400, David Walter wrote:
> I don't know about the  lynx www.slashdot.org problem,

Look at this part of the lynx screen:

                                          Older Stuff

   Wednesday August 28
   · A New Model for Software Innovation (291)
   · Warflying: San Diego (163)
   · Literate Programming and Leo (362)
...
especially the first columuns, and press page up + page down a couple of
time.  YOu should see distortions.

> hadn't been to  slashdot with  lynx  in the console-ncurses). But  the
> following fixes couple of things, if cons_init fails, it cleans up the
> console,

Ok, I put this in.

> and  this seems to correctly restore   the cursor location in
> emacs  and in the irc  client that I  am using scrollz, which are both
> still  repeatable for me  with  the latest  cvs versions  of console &
> libcons.

I see.  I had the code originally as you submit it now, and used the other
routines following a comment in the ncurses man page.  But the ncurses man
page said also that you had to submit the change immediately, and now that I
think about it I don't think it is the same case here as mentioned in the
manpage of getsyx.  So I put it in.

Next time, please watch out for GNU coding style issues (the indentation was
messed up in your patch), and write a changelog entry (see below).

Thanks for your patch!
Marcus

2002-08-29  Marcus Brinkmann  <marcus@gnu.org>

        * console-ncurses.c (main): Call endwin () before bailing out
        because of an error.
        (cons_vcons_write): Use getyx and wmove on stdscr instead getsyx
        and setsyx (which operate on newscr, and mess up the cursor
        anyway, probably because we don't commit the change immediately).
        Submitted by David Walter <dwalter@syr.edu>.


-- 
`Rhubarb is no Egyptian god.' GNU      http://www.gnu.org    marcus@gnu.org
Marcus Brinkmann              The Hurd http://www.gnu.org/software/hurd/
Marcus.Brinkmann@ruhr-uni-bochum.de
http://www.marcus-brinkmann.de/