Re: New bitmap code - testers required

[Pete French]

> Thank you for you patch. It is working better now and the image does scale
> in the Content Inspector of GWorkspace.app. It also displays png's :-).

That impressive - I posted that from work, and by the time I get home I
have some test results :-) Excellent. I dont have GWorkspace.app here,
perhaps getting a copy would be useful for testing - I tried Gorm and
ProjectBuilder.

> (1) It crashes sometimes. Please see attached file for a backtraces.

Hmm, thats interesting - the crash is in a piece of code I didnt touch at
all, so the behaviour should be no different. Possibly I am corrupting
memory somewhere along the way ? Does this always happen on the same
image, and if so could you send me that image so I can see how the decoding is
being done and to verify that it is doing that part properly ?

I havewnt looked into compositing yet - my main aim was to get drawInRect
working properly and to make the images honour PSscale. But it was the
next thing I was going to delve into, so I might as well start now.

> (2) It is extremely slow. Maybe there should some type of thumbnail caching
> for GWorkspace.app is in order.

Are you drawing a large image into a very small space every time ? It
shouldnt be any slower than before to display a normal 8 bit image, but
minification will slow it down considerably, as will reading from any oddly
aligned bitmap structure. Cacheing a created thumbnail is probably a very
good idea in general.

If it breaks on a specific image then send me that and I will take a look,

cheers,

-bat.