Re: master e5392d3: Make easymenu downcase the menu symbol for greater backwards compat

[Lars Ingebrigtsen]

Glenn Morris <rgm@gnu.org> writes:

>>     Make easymenu downcase the menu symbol for greater backwards compat
>
> This may be more compatible for the goal of "replace old-style menu
> definitions with easymenu ones", but it is an incompatible change for
> any menus already defined with easymenu, which may be accessed by any
> code outside of Emacs.
>
> Eg term-mode-map used to contain "Signals", now it contains "signals".

Yup.  But I searched through both the Emacs tree and GNU ELPA and didn't
find a single instance of any upper-case menu `lookup-key' calls, so I
thought the likelihood of breakages was sufficiently small to make the
(incompatible) change.  But it should probably be called out in NEWS.

Changing `lookup-key' to accept both forms (like Eli) suggests in a
followup would be better, of course, if it can be done efficiently.

easymenu should also be extended with a form to allow explicitly
specifying the symbol to use: For instance, if you change the name of
the menu now, the symbol will also change.  So for backwards
compatibility, symbols should be specified when changing the name in
easymenu calls.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no