emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 432c1aa: Use `pop-to-buffer-same-window' in `project-eshell'


From: Theodor Thornhill
Subject: Re: master 432c1aa: Use `pop-to-buffer-same-window' in `project-eshell'
Date: Sun, 21 Mar 2021 08:04:13 +0100

Hi, Eli!

> "use", in plural.  Also, the first line of a NEWS entry should be a
> complete sentence, so it should end with a period.
>
>> +This is to keep the same behavior as eshell has.
>
> I believe our convention is to use "Eshell", capitalized.
>

New patch with your comments addressed, hopefully sufficiently :)

> Thanks.

Thank you :)

--
Theo

Attachment: 0001-Use-pop-to-buffer-same-window-for-shell.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]