emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 6ed1994d27: Prevent crashes from illegal locale coding system


From: Eli Zaretskii
Subject: Re: master 6ed1994d27: Prevent crashes from illegal locale coding systems
Date: Sun, 13 Feb 2022 15:45:36 +0200

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Sun, 13 Feb 2022 21:16:19 +0800
> 
> Decoding multibyte X keyboard input and XIM pre-edit text with any
> coding system other than the actual locale coding system will result in
> nonsensical text.

But even nonsensical text is better than no text at all, don't you
agree?

And anyway, in what possible encodings could this text be?  Can't we
detect the encoding with reasonable success rate?

I mean, dropping input on the floor, let alone doing that silently, is
pretty rough, no?

> > And how come locale-coding-system is not a valid coding-system there
> > in the first place?
> 
> The user could have set it to an invalid value, which leads to
> spectacular crashes when setup_coding_system signals inside a GTK event
> filter.

Can't we catch those signals?

If we cannot catch these signals, it probably means it is unsafe to
call decoding routines in that place anyway.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]