Re: [ELPA] propose to add vundo.el to ELPA

[Michael Heerdegen]

Yuan Fu <casouri@gmail.com> writes:

> I wrote vundo.el a while ago and it’s now quite stable. It displays
> the undo history in a tree form like undo-tree. Unlike undo-tree,
> vundo doesn’t require you to replace undo commands and track changes
> itself, rather it generates the tree fresh from ‘buffer-undo-list’. Do
> you think vundo would be a good addition to ELPA?

Tried it out shortly.  Looks very useful and cool and easy to use and
well done.

Some minor comments:

- Maybe mention the arrow keys in the introduction (that they work)?

- In undo-tree, one had to select a different branch before one could
"walk" into it.  For vundo it's the other way round: you first have to
select the first element of the active branch, after the root, and only
after that you can activate a different (sibling) branch (or did
undo-tree add virtual roots or so?).  Dunno what interface approach I
like more.  But because I had tried undo-tree, your approach feels
unfamiliar.  Dunno how others see that (AFAIR, undo-tree felt strange
in the same aspect when I had tried it first, too=.

- Question: here in the comment:

;; update. Vundo catches up the next time you invoke any command:
;; instead of performing that command, it updates the tree.

do you mean "next time you invoke any _vundo_ command"?  Otherwise I
don't understand the sentence - buffer changes happen via commands - so
what command actually do update?

- And here are some typos I think (without warranty, I'm not perfectly
speaking English):

>From 93248a5f359153ec272871dbbe41a5a450c9ef87 Mon Sep 17 00:00:00 2001
From: Michael Heerdegen <michael_heerdegen@web.de>
Date: Tue, 5 Apr 2022 05:32:42 +0200
Subject: [PATCH] Some typos

---
 vundo.el | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/vundo.el b/vundo.el
index 27a6368..f16df2e 100644
--- a/vundo.el
+++ b/vundo.el
@@ -27,7 +27,7 @@
 ;;; Commentary:
 ;;
 ;; To use vundo, type M-x vundo RET in the buffer you want to undo.
-;; A undo tree buffer should pop up. To move around, type:
+;; An undo tree buffer should pop up. To move around, type:
 ;;
 ;;   f   to go forward
 ;;   b   to go backward
@@ -36,7 +36,7 @@
 ;;   q   to quit, you can also type C-g
 ;;
 ;; By default, you need to press RET to “commit” your change and if
-;; you quit with q or C-g, the change made by vundo are rolled back.
+;; you quit with q or C-g, the changes made by vundo are rolled back.
 ;; You can set ‘vundo-roll-back-on-quit’ to nil to disable rolling
 ;; back.
 ;;
@@ -66,7 +66,7 @@
 ;;
 ;; Your default font needs to contain these Unicode characters, otherwise
 ;; they look terrible and don’t align. You can find a font that covers
-;; these characters (eg, Symbola, Unifont), and set ‘vundo-default’ face
+;; these characters (e.g. Symbola, Unifont), and set ‘vundo-default’ face
 ;; to use that font:
 ;;
 ;;     (set-face-attribute 'vundo-default nil :family "Symbola")
@@ -114,14 +114,14 @@
 ;; Position-only records
 ;;
 ;; We know how undo works: when undoing, ‘primitive-undo’ looks at
-;; each record in ‘pending-undo-list’ and modify the buffer
+;; each record in ‘pending-undo-list’ and modifies the buffer
 ;; accordingly, and that modification itself pushes new undo records
 ;; into ‘buffer-undo-list’. However, not all undo records introduce
 ;; modification, if the record is an integer, ‘primitive-undo’ simply
 ;; ‘goto’ that position, which introduces no modification to the
 ;; buffer and pushes no undo record to ‘buffer-undo-list’. Normally
 ;; position records accompany other buffer-modifying records, but if a
-;; particular record consist of only position records, we have
+;; particular record consists of only position records, we have
 ;; trouble: after an undo step, ‘buffer-undo-list’ didn’t grow, as far
 ;; as vundo tree-folding algorithm is concerned, we didn’t move.
 ;; Assertions expecting to see new undo records in ‘buffer-undo-list’
-- 
2.30.2

but I only read the commentary partly and quickly.  Also only tried
quickly, but looks really cool.

Michael.