Re: [ELPA] propose to add vundo.el to ELPA

[Michael Heerdegen]

Yuan Fu <casouri@gmail.com> writes:

> Thanks, applied!

Ok, 3 little more:

From 2820d87b9d10f87921677560aae141a8dd43f6d4 Mon Sep 17 00:00:00 2001
From: Michael Heerdegen <michael_heerdegen@web.de>
Date: Fri, 8 Apr 2022 00:43:20 +0200
Subject: [PATCH] Three more tyos

---
 vundo.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/vundo.el b/vundo.el
index f16df2e..4de45de 100644
--- a/vundo.el
+++ b/vundo.el
@@ -91,12 +91,12 @@
 ;; `vundo-m' object corresponding to it. Once we have the mod-list and
 ;; hash table, we connect the nodes in mod-list to form a tree in
 ;; `vundo--build-tree'. We build the tree by a simple observation:
-;; only non-undo modifications creates new unique buffer states and
+;; Only non-undo modifications create new unique buffer states and
 ;; need to be drawn in the tree. For undo modifications, they
-;; associates equivalent nodes.
+;; associate equivalent nodes.
 ;;
 ;; Once we have generated the data structure and drawn the tree, vundo
-;; commands can move around on that tree by calling
+;; commands can move around in that tree by calling
 ;; `vundo--move-to-node'. It will construct the correct undo-list and
 ;; feed it to `primitive-undo'. `vundo--trim-undo-list' can trim the
 ;; undo list when possible.
--
2.30.2


Some more ideas/thoughts:

(1) If you use `vundo' for the first time in a buffer with an already
very large undo list, do you expect a delay?  Would it make sense to
limit the processing of `buffer-undo-list' to the last N entries to
avoid such a delay (N would probably be a user option)?

(2) I wonder which setup I will prefer in the future.  I'm using the
commands that already "fold" the undo list (AFAIU, in the same or a
similar sense as vundo does): `undo-only' and `undo-redo'.  Do these
commands directly correspond to hitting right and left in the vundo
buffer?

If yes, I think it would be cool to setup stuff that the keys I use for
`undo-only' and `undo-redo' would work like now but additionally start
vundo.  And the same keys would still work in vundo and call
vundo-backward and vundo-forwar, additionally to the existing bindings.
I think that could feel convenient.  Would such a setup make sense to
you?

Thanks,

Michael.