Re: [ELPA] propose to add vundo.el to ELPA

[Philip Kaludercic]

Yuan Fu <casouri@gmail.com> writes:

>> On Apr 5, 2022, at 12:23 AM, Philip Kaludercic <philipk@posteo.net> wrote:
>> 
>> Yuan Fu <casouri@gmail.com> writes:
>> 
>>> Hi,
>>> 
>>> I wrote vundo.el a while ago and it’s now quite stable. It displays
>>> the undo history in a tree form like undo-tree. Unlike undo-tree,
>>> vundo doesn’t require you to replace undo commands and track changes
>>> itself, rather it generates the tree fresh from ‘buffer-undo-list’. Do
>>> you think vundo would be a good addition to ELPA?
>> 
>> I certainly think it would be, and would be glad to help with any
>> packaging needs.
>
> Thanks. Here is a patch for ELPA.

I would apply this then, given no other objections.

> Yuan
>
> From 26c0aaf44d96e3a8b74b6f55421f791a39cf3ad9 Mon Sep 17 00:00:00 2001
> From: Yuan Fu <casouri@gmail.com>
> Date: Tue, 5 Apr 2022 21:21:07 -0700
> Subject: [PATCH] * elpa-packages ("vundo"): New package.
>
> ---
>  elpa-packages | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/elpa-packages b/elpa-packages
> index e218968e87..8fb17c4baf 100644
> --- a/elpa-packages
> +++ b/elpa-packages
> @@ -630,6 +630,12 @@
>   ("vertico-posframe"
>    :url "https://github.com/tumashu/vertico-posframe";
>    :auto-sync t)
> + ("vundo"
> +  :url "https://github.com/casouri/vundo";
> +  :ignored-files ("test")
> +  :doc "README.txt"
      ^
      I am assuming this is supposed to be a :readme, not a :doc.
      Or do you actually want to create a manual out of the README?

      As your commentary section seems to intentionally mirror the
      README (if this is the right thing is a different question.  I
      don't know why a package.el user is interested in testing if the
      testing code isn't bundled in the package), this could just be
      dropped.

> +  :news "NEWS.txt"

I see that your README also contains a news section.  It might make
sense only maintain the news in one of the two, to avoid duplication on
elpa.gnu.org.

Besides that, it seems to be that the introduction in README.txt doesn't
immediately explain what the package is about.  This might confuse
people using C-h P to preview the package before installing it.

> +  :auto-sync t)
>   ("wcheck-mode"              :url "https://github.com/tlikonen/wcheck-mode";)
>   ("wconf"            :url "https://github.com/ilohmar/wconf";)
>   ("web-server"               :url 
> "https://github.com/eschulte/emacs-web-server.git";)

-- 
        Philip Kaludercic