[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [ELPA] propose to add vundo.el to ELPA
From: |
Yuan Fu |
Subject: |
Re: [ELPA] propose to add vundo.el to ELPA |
Date: |
Wed, 6 Apr 2022 10:52:37 -0700 |
>>
>> diff --git a/elpa-packages b/elpa-packages
>> index e218968e87..8fb17c4baf 100644
>> --- a/elpa-packages
>> +++ b/elpa-packages
>> @@ -630,6 +630,12 @@
>> ("vertico-posframe"
>> :url "https://github.com/tumashu/vertico-posframe"
>> :auto-sync t)
>> + ("vundo"
>> + :url "https://github.com/casouri/vundo"
>> + :ignored-files ("test")
>> + :doc "README.txt"
> ^
> I am assuming this is supposed to be a :readme, not a :doc.
> Or do you actually want to create a manual out of the README?
That should be README.
>
> As your commentary section seems to intentionally mirror the
> README (if this is the right thing is a different question. I
> don't know why a package.el user is interested in testing if the
> testing code isn't bundled in the package), this could just be
> dropped.
Should I let ELPA ignore README.txt and only use Commentary then?
>
>> + :news "NEWS.txt"
>
> I see that your README also contains a news section. It might make
> sense only maintain the news in one of the two, to avoid duplication on
> elpa.gnu.org.
>
> Besides that, it seems to be that the introduction in README.txt doesn't
> immediately explain what the package is about. This might confuse
> people using C-h P to preview the package before installing it.
Thanks. I fixed those points and here is the new patch. In this patch I removed
README.txt. If it turns out to be not desirable, I can make another patch.
Yuan
vundo.patch
Description: Binary data
Re: [ELPA] propose to add vundo.el to ELPA, Philip Kaludercic, 2022/04/05
Re: [ELPA] propose to add vundo.el to ELPA, Stefan Monnier, 2022/04/06