Re: master 5b3c4004a9 2/2: Remove calls to intern with a static string from code that runs on X

[Po Lu]

Gregory Heytings <gregory@heytings.org> writes:

> It isn't, but what we ask to anyone who reports a bug is to provide a
> minimal recipe starting with emacs -Q.  I don't see why the problem
> you see would be different.

Because this is a bug that occurs before Emacs has been built, so the
buggy Emacs cannot be started with "emacs -Q".

> Anyway, I've now changed the way the message is displayed, it now uses
> three leading stars and is redirected to stderr, which is e.g. what
> the Linux kernel uses.  Does that fix your problem?

That does, yes.

> I guess it's a matter of taste.  To me this (which is the only message
> that most people will ever see):
>
> "make all" failed with exit status 2.
> You might try to:
> - run "make bootstrap", which might fix the problem
> - run "make V=1", which displays the full commands invoked by make,
>   to further investigate the problem
>
> immediately tells me that there is a build failure, and that I have
> two options: "make bootstrap" to try to fix the problem, and "make
> V=1" to investigate the problem.  What is unclear to you in that
> message?

What is the point of all the "might try to".  It's not that the message
is unclear; it is hard to understand until you read it at least twice in
both directions.