Re: toml-ts-mode: first draft

[Jostein Kjønigsen]

On 12.12.2022 00:01, Yuan Fu wrote:
> Looks great!
Thanks!
> +  (unless (treesit-ready-p 'toml)
> +    (error "Tree-sitter for TOML isn't avilable”))
>
> Treesit-ready-p already raises a warning when something goes wrong. So you want 
> to either pass the QUIET argument or let it do the barking ;-)
>
> Yuan

Sure, I can fix that.

I notice though that this is not applied consistently in the other 
tree-sitter based major-modes.

From json-ts-mode.el:

>  (unless (treesit-ready-p 'json)
>   (error "Tree-sitter for JSON isn't available"))

From csharp-mode.el:

>  (unless (treesit-ready-p 'c-sharp)
>    (error "Tree-sitter for C# isn't available"))

From typescript-ts-mode.el:

>  (when (treesit-ready-p 'tsx)
>    (treesit-parser-create 'tsx)

From python.el:

>  (when (treesit-ready-p 'python)
>    (treesit-parser-create 'python)

I see in the (treesit-ready-p) it clearly throws when language is missing.

So from what I can tell all of the "established" forms are doing too much:

* checking return-value (not required because of throwing)
* creating errors

Could you recommend 1 specific form, and I'll try to stick to that, at 
least for toml-ts-mode (and then we can clean up those other modes later 
on).

--
Jostein