[glob2-devel] Re: level 1 buildings not repairable?

[Joe Wells]

Cyrille Dunant <address@hidden> writes:

> On Thursday 12 April 2007 09.46:59 Stéphane Magnenat wrote:
>> On Thursday 12 April 2007 09:35:33 Joe Wells wrote:
>> > Stéphane Magnenat <address@hidden> writes:
>> > > Those functions call the one that triggers the assert. But the
>> > > problem, as far as I've traced it, is that a level 1 building site
>> > > is in repair mode, which is forbidden, because it does not have a
>> > > previous building and thus the assert is triggered because previous
>> > > building lookup returns -1.
>> >
>> > I'm confused.  I discovered this bug repairing level 1 buildings.  Are
>> > you saying that level 1 buildings are not supposed to be repairable?
>>
>> No, I say that *building sites* are not supposed to be reparable, and that
>> implies that if they are, and they are level one, nasty things happen
>> because it does not have a previous building.
>
> My bet is that someone made building sites reparable, or got rid of an if...

When I discovered this bug, I remember repairing genuine level 1
buildings, not building sites.  (This was after a battle in which
several inns and hotels were damaged.)  So my big question is:  Why
did the code think my _buildings_ were building _sites_?

-- 
Joe