Re: GNUstep releases this month?

[Richard Frith-Macdonald]

> On 2 Mar 2021, at 23:57, Riccardo Mottola <riccardo.mottola@libero.it> wrote:
> 
> Hi all!
> 
> some important work was done the past fortnight...  Richard and I did great 
> stuff in base!
> 
> I had two concerns for a release
> 1) in back we have a strange issue which is going on since past year and 
> which affects only windowmaker: on launch the app-icon was at first black, 
> now it is totally grey. It comes from various "fixes" Sergei did, but which 
> actually caused a regression compared to the old buggy code of the past 
> release! The bug happens only with the xlib and cairo backend, the art 
> backend just works fine.
> 
> 2) mingw 64bit stopped working on several installation recently.  While the 
> latest changes where thought to be the cause, actually it was old code using 
> a mix of old and even older win32 functions. Working with Fred, I cleaned 
> them all up to the newer level.
> 
> I commited this tonight on a special "win64-fixes" branch - should be merged 
> before release.
> 
> I think this fix is very important, things just worked "by chance" for a long 
> time and possibly broke with a mingw or windows update! It absolutely should 
> get into release if it is confirmed to work (or even not to harm, since it 
> improves for me and is technically correct)
> 
> I encourage Richard and Gregory to test this branch and if it works for them, 
> thumbs up.

I haven't actually tested, but I did look at the diffs and read up on the 
difference between Get/SetWindowLong and Get/SetWindowLongPtr, and it all makes 
sense to me ... I was unable to reproduce the problem on my system simply 
because, thorugh chance, the windows the system was giving me all existed in 
the low part of the address space.
The only error is spotted in the change was in WIN32Server.m when styling a 
popup window ... here LONG (32bit) is used to hold the style information, where 
the API requires LONG_PTR (64bit).
This would have the catastrophic effect of losing style information for popup 
windows for all those many users of 64bit windows on a big-endian CPU :-)