Re: [PATCHES] Re: Harp Pedals?

[Reinhold Kainhofer]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Montag, 18. August 2008 schrieb Neil Puttock:
> 2008/8/18 Reinhold Kainhofer <address@hidden>:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Am Montag, 18. August 2008 schrieb Han-Wen Nienhuys:
> >> On Sun, Aug 17, 2008 at 9:10 PM, Reinhold Kainhofer
> >>
> >> <address@hidden> wrote:
> >> > Attached is a patch for stencil.scm, which adds a make-line-stencil
> >> > that does exactly that: You call it as
> >> >    (make-line-stencil linewidth xstart ystart xend yend)
> >> > and it will create the stencil and correctly set its extent (adding
> >> > half the line width to all coordinates, too).
> >> >
> >> > Okay to apply to master?
> >>
> >> make sure that duplicate code with the draw-line markup is eliminated
> >
> > Done, patch is attached. Okay to apply?
>
> There's a subtle difference in backslashed digits, though I wouldn't
> have noticed without running make check (see attached image).

Yes, but that's actually a fix ;-) The slash stencil was using wrong extents 
(and it was completely ignoring the line thickness, too).

> There's a rogue "}" in the markup command snippet which breaks docs
> compilation.
>
> fret-diagram-details is listed in the used props.

Oops to both. I copied the structure from the fret diagrams and missed the 
props...

> The snippet should be moved to the end of the description.  "For
> example .... produces a harp pedal diagram." is redundant.

Okay. I simply took the structure from the fret diagrams...

> There's a missing @item before the first harp-pedal-details prop in
> define-grob-properties.scm.

Ah, I saw that the bullet was missing in the html file and looked for the 
reason, but I was too blind to see that an @item was missing!

Amended patch is attached.

> Version should be 2.11.57.

lilypond --version produces 2.11.56 here. Why should I be using 2.11.57?

Cheers,
Reinhold


- -- 
- ------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
 * K Desktop Environment, http://www.kde.org, KOrganizer maintainer
 * Chorvereinigung "Jung-Wien", http://www.jung-wien.at/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIqfNYTqjEwhXvPN0RAq97AKCJSyR3Ksu12WnEtl0t/rBxins8kACfWlSK
p+6NgPW9o56zPscKqNMmtFk=
=1Tda
-----END PGP SIGNATURE-----

0002-Feature-Add-Harp-pedal-diagrams-i.e.-a-harp-pedal.patch
Description: Text Data