Re: [PATCHES] Re: Harp Pedals?

[Neil Puttock]

2008/8/18 Reinhold Kainhofer <address@hidden>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am Montag, 18. August 2008 schrieb Han-Wen Nienhuys:
>> On Sun, Aug 17, 2008 at 9:10 PM, Reinhold Kainhofer
>>
>> <address@hidden> wrote:
>> > Attached is a patch for stencil.scm, which adds a make-line-stencil that
>> > does exactly that: You call it as
>> >    (make-line-stencil linewidth xstart ystart xend yend)
>> > and it will create the stencil and correctly set its extent (adding half
>> > the line width to all coordinates, too).
>> >
>> > Okay to apply to master?
>>
>> make sure that duplicate code with the draw-line markup is eliminated
>
> Done, patch is attached. Okay to apply?

There's a subtle difference in backslashed digits, though I wouldn't
have noticed without running make check (see attached image).

> Attached is now a patch for master, which adds the functionality directly to
> lilypond, together with proper documentation for the appendix of the NR and
> the IR. I've not written anything for the NR "2.3.3.1 Harp", though.
>
> Okay to apply to master?

The patch looks great; it'll actually make having a harp section in
the docs worthwhile. :)

Just a few minor quibbles:

There's a rogue "}" in the markup command snippet which breaks docs compilation.

The snippet should be moved to the end of the description.  "For
example .... produces a harp pedal diagram." is redundant.

fret-diagram-details is listed in the used props.

There's a missing @item before the first harp-pedal-details prop in
define-grob-properties.scm.

Version should be 2.11.57.

Regards,
Neil

lily-e9544f5b.compare.jpeg
Description: JPEG image