Re: Enabling item-interface

[Carl D. Sorensen]

On 3/2/09 11:37 PM, "Joe Neeman" <address@hidden> wrote:

> On Mon, 2009-03-02 at 21:05 -0700, Carl D. Sorensen wrote:
>> I'm working to enable the chordChanges property for a FretBoards object.
>> 
>> I've changed the fretboard-engraver to keep track of the last fretboard,
>> using the chord-name-engraver as a model.  I've verified that the code works
>> to keep track of the changes in the fretboards.
>> 
>> Here's the relevant code from fretboard-engraver.
>> 
>>   SCM changes = get_property("chordChanges");
>>   if (to_boolean (changes) && scm_is_pair(last_fret_notes_)
>>       && ly_is_equal (last_fret_notes_, fret_notes))
>>     fret_board_->set_property ("begin-of-line-visible", SCM_BOOL_T);
> 
> Why does ChordName use 'begin-of-line-visible = #t instead of
> 'break-visibility = begin-of-line-visible like all the other items?
> That's why this change doesn't work AFAICT: chord-name.cc has extra
> logic to deal with the 'begin-of-line-visible property that doesn't
> apply to FretBoard.

Thanks, Joe.  I had mixed up begin-of-line-visible as a property with
begin-of-line-visible as a value of the break-visibility property.

I suspect that ChordName uses begin-of-line-visible rather than
break-visibility because, as Patrick suggests in his email, ChordName never
appears at the beginning of a line (i.e.it's after the clef, and the key
signature, etc.)

Thanks for the tip.  I'll chase down the begin-of-line-visible property.

Carl