|
From: | Trevor Daniels |
Subject: | Re: an LM update |
Date: | Mon, 23 Mar 2009 15:48:37 -0000 |
James E. Bailey wrote Monday, March 23, 2009 2:15 PM
Am 23.03.2009 um 14:54 schrieb Graham Percival:On Mon, Mar 23, 2009 at 02:50:45PM +0100, James E. Bailey wrote:Am 23.03.2009 um 14:14 schrieb Graham Percival:On Mon, Mar 23, 2009 at 02:03:56PM +0100, James E. Bailey wrote:Yes, I did git commit -a and had the line : Modified: Documentation/user/tutorial.itely in that file. The problem is that I don't havegit-format-patch. bash reports command not found.Sorry, you're (quite sensibly) looking at the docs on lilypond.org. Unfortunately, they're a bit out of date now; in particular, they miss this fix. Please see here for the most up-to-date version. http://www.kainhofer.com/~lilypond/Documentation/devel/contrib- guide/Sharing-your-changes.htmlThanks, that solved the problem of the error, but now I don't knowwhichfile I email. Apparently, I've successfully updated my branch by 1commit, but, do I send the whole tutorial.itely file? or what should I look for, as far as changed files?Good point. There should be a file called 0001-something in the top of the git directory. That's what you send. I'll add this to the CG. Cheers, - GrahamIs it just me, or did the website have git format-patch HEAD a minuteor two ago?In any event, hopefully this is an acceptable patch. Whether or not introduction of single-staff polyphony should be kept at this point in the LM (since doing so does not follow Documentation policy) is adifferent conversation.
The good news is the patch works fine and the docs still compile with it applied. So I've applied it and pushed it to origin/master. I can't say I'm wild about it, as it uses so many concepts which have not been introduced at that point, so it will probably be moved when I get back to working on the LM, but in an odd-numbered release I'm prepared to accept it.
But, as I said before, I think that removing it altogether is also abad idea. Perhaps a simple warning that the section introducesseveral new concepts that haven't been fully explained with links to the appropriate sections that do explain them fully would be enough.
Would you like to prepare another patch which does this? That would be an improvement. Thanks for your help! Trevor
[Prev in Thread] | Current Thread | [Next in Thread] |