|
| From: | dak |
| Subject: | Re: Don't hardcode a limited set of markup signatures. (issue969046) |
| Date: | Mon, 03 May 2010 08:22:24 +0000 |
On 2010/05/02 16:34:12, hanwenn wrote:
On Sun, May 2, 2010 at 8:04 AM, <mailto:address@hidden> wrote: > > http://codereview.appspot.com/969046/diff/7001/8002 > File lily/lexer.ll (right): > > http://codereview.appspot.com/969046/diff/7001/8002#newcode545 > lily/lexer.ll:545: // loop will be EXPECT_NO_MORE_ARGS. > On 2010/05/01 19:56:08, hanwenn wrote: >> >> wouldnt it be clearer to have a function > >> void translate_markup_signature(SCM predicate_list, >> vector<int> expect_tokens);
The quality of the current code is not an argument to not improve over it. The current code is largely from my hand, but there are many things I would do differently today for many reasons.
Patches will be thoughtfully considered. http://codereview.appspot.com/969046/show
| [Prev in Thread] | Current Thread | [Next in Thread] |