Re: Build: another hack for translations (fix 1323). (issue2520041)

[John Mandereau]

Il giorno dom, 17/10/2010 alle 18.28 +0000, address@hidden
ha scritto:
> On 2010/10/17 16:52:03, John Mandereau wrote:
> > python/auxiliar/postprocess_html.py:357: extra_depth = '../'
> > '../' is is not needed for translations, as output web pages are at
> the same
> > depth as the pages in English, and may cause errors in case server
> configuration
> > doesn't redirect /.. to /. I suggest to simply remove all extra_depth
> stuff.
> 
> Are you sure about that?  After disabling the
> (make the "return to doc index" work) stuff

Do you mean your patch?  It seems so from the file paths in URLs you
quote below.  I mean, your patch does a good job, except that given the
path substitution you add, it is not necessary to add an extra "../" for
translations, despite the discrepancy between English docs and
translations in the output without your patch.


>  and building the online
> docs, I see this:
> 
> **** notation/index.es.html
> <p class="toc_uplink"><a
> href="../../..//Documentation/web/manuals.es.html"
>           title="Documentation Index">&lt;&lt; Volver al índice de la
> documentación</a></p>
> 
> **** notation/index.html
> <p class="toc_uplink"><a href="../..//Documentation/web/manuals.html"
>           title="Documentation Index">&lt;&lt; Back to Documentation
> Index</a></p>
> 
> 
> so it seems to me that we need the extra_depth for the old_link, at
> least.

With your patch I got

"""
<a href="../../../../../website/development.it.html"
         title="Documentation Index">&lt;&lt; Torna all'indice della 
documentazione</a>
"""

in out-www/online-root/Documentation/learning/index.it.html, so you see
there is an extra "../" (the doc root is at depth 2 on lilypond.org and
this page is at depth 2 from doc root); BTW it should also be
"manuals.it.html", not "development...".  I'm commenting this in on
Rietveld.


>   Now, I'm willing to believe that we don't need it for the
> devel_link and manual_link (i.e. the new links)... those are much more
> awkward to test, so I haven't done that yet.

I haven't verified those.

Cheers,
John

signature.asc
Description: This is a digitally signed message part