lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Cleanup beam scoring code. (issue4001046)


From: Han-Wen Nienhuys
Subject: Re: Cleanup beam scoring code. (issue4001046)
Date: Wed, 2 Feb 2011 12:54:36 -0200

On Wed, Feb 2, 2011 at 3:49 AM, Werner LEMBERG <address@hidden> wrote:
>> There is one diff remaining: see the attached file.  I introduced
>> some streamlining of an inner loop, which affects the way we handle
>> beams that start/end with invisible stems.
>>
>> The compare image is the new one.  I have no examples of tremolo beams
>> handy, but the new layout actually looks better to me.
>
> For me, it doesn't.  While the old behaviour is not optimal, the new
> one looks really worse to me, especially in bar 3 (which is admittedly
> a quite artificial example).  The most important issue for me: Why is
> there no slant of the beams?  I currently have not enough time to

But the old version also had no slant?  I'm inclined to take interpret
all these answers as "tremolo on whole notes was broken, and it still
is, just differently," and commit.

My concern is about breaking something that was working as intended before.

-- 
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen



reply via email to

[Prev in Thread] Current Thread [Next in Thread]