Re: Add Modal transformations (issue4126042)

[tdanielsmusic]

> Might it be worth having some predefined scales,
> i.e. \diatonicScale and \pentatonicScale and the like?

I don't think so; they are not unique.  Even a chromatic scale can be
written using many combinations of naming the enharmonically equivalent
notes.  You might argue that a C major scale is somehow more basic, but
that's only because it corresponds with the white notes on a piano ;)


http://codereview.appspot.com/4126042/diff/4002/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):

http://codereview.appspot.com/4126042/diff/4002/Documentation/notation/pitches.itely#newcode823
Documentation/notation/pitches.itely:823: In a musical composition that
is based on a scale, a motive is frequently transformed in various ways.
> wrap at 72 chars, please.

Done

http://codereview.appspot.com/4126042/diff/4002/Documentation/notation/pitches.itely#newcode824
Documentation/notation/pitches.itely:824: It may be @emph{transposed} to
start at different

> No @emph here, since the reader already knows about
> tranposition.

As this sentence is introducing the three transformations I want them
all to have the same appearance, so I changed them all to notation{}

http://codereview.appspot.com/4126042/diff/4002/Documentation/notation/pitches.itely#newcode825
Documentation/notation/pitches.itely:825: places in the scale, it may be
@emph{inverted} around
> Technically, this should be @notation{inverted},

Done.

http://codereview.appspot.com/4126042/diff/4002/Documentation/notation/pitches.itely#newcode828
Documentation/notation/pitches.itely:828: Lilypond provides functions
that may be used to apply these transformations to a motive.
On 2011/02/01 23:15:34, Graham Percival wrote:

> I don't think we need a whole paragraph-sentence for this.

Done.

http://codereview.appspot.com/4126042/diff/4002/Documentation/notation/pitches.itely#newcode831
Documentation/notation/pitches.itely:831: Any note that does not is left
untransformed.}
On 2011/02/01 23:15:34, Graham Percival wrote:
> This could be rewritten with half the number of words,
> and a clearer single sentence.  And since it's inside a
> @warning, I'm going to insist on it.

Done.

http://codereview.appspot.com/4126042/diff/4002/Documentation/notation/pitches.itely#newcode838
Documentation/notation/pitches.itely:838: @funindex \modalTranspose
On 2011/02/01 23:15:34, Graham Percival wrote:
> at the moment, we're writing out (elsewhere in the docs)
> funindex \foo
> funindex foo

Done.

http://codereview.appspot.com/4126042/diff/4002/Documentation/notation/pitches.itely#newcode840
Documentation/notation/pitches.itely:840: A motive can be transposed
within a given scale.  The syntax is
On 2011/02/01 23:15:34, Graham Percival wrote:

> Remove "the syntax is".

Done.

http://codereview.appspot.com/4126042/diff/4002/Documentation/notation/pitches.itely#newcode851
Documentation/notation/pitches.itely:851: motive = \relative c' { c8 d e
f g a b c }
Good catch!  Done.

http://codereview.appspot.com/4126042/diff/4002/Documentation/notation/pitches.itely#newcode862
Documentation/notation/pitches.itely:862: Any scale may be specified.
Here is an example with a pentatonic scale:
On 2011/02/01 23:15:34, Graham Percival wrote:

> Remove "Here is an example..."

Done.

http://codereview.appspot.com/4126042/diff/4002/Documentation/notation/pitches.itely#newcode871
Documentation/notation/pitches.itely:871: \modalTranspose ges ees'
\blackNoteScale \motive
On 2011/02/01 23:15:34, Graham Percival wrote:

> What's wrong with \pentatonic?  or pentatonicScale ?

Done.

http://codereview.appspot.com/4126042/diff/4002/Documentation/notation/pitches.itely#newcode899
Documentation/notation/pitches.itely:899: A motive can be inverted
within a given scale around a given pivot note.  The syntax is
On 2011/02/01 23:15:34, Graham Percival wrote:

> Remove "the syntax is"

Done.

http://codereview.appspot.com/4126042/