lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add Modal transformations (issue4126042)


From: pkx166h
Subject: Re: Add Modal transformations (issue4126042)
Date: Thu, 03 Feb 2011 10:14:46 +0000


http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):

http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely#newcode828
Documentation/notation/pitches.itely:828: Lilypond provides functions
for applying these transformations.
Do we need this last sentence 'Lilypond provides..'.

If so 'LilyPond' not 'Lilypond'.

http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely#newcode862
Documentation/notation/pitches.itely:862: @end lilypond
This maybe showing my ignorance here, but do we need the '\score' and/or
'\new Staff' between the @Lilypond and @end Lilypond constructs? - for
the sake of simplifying the examples.

http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely#newcode868
Documentation/notation/pitches.itely:868: motif = \relative c' { ees8
des ges,4 <ges' bes,> <ges bes,>}
Minor nitpick. need a space before the closing '}'

http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely#newcode912
Documentation/notation/pitches.itely:912: opposite direction:
I had to read this a few times for to make sense to me, so how about
instead:

The notes of @var{motif} are placed the same number of scale degrees
from the @var{pivot} note within the @var{scale}, but in the opposite
direction.

http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely#newcode953
Documentation/notation/pitches.itely:953: The combined operation of
inversion and retrograde produce the
The combined operation of @code{inversion} and @code{retrograde} ...

http://codereview.appspot.com/4126042/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]