Re: Add Modal transformations (issue4126042)

[Trevor Daniels]

Changes made in http://codereview.appspot.com/4079064/

----- Original Message ----- 
From: <address@hidden>
Sent: Friday, February 04, 2011 10:24 AM
Subject: Re: Add Modal transformations (issue4126042)


> http://codereview.appspot.com/4126042/diff/3009/Documentation/notation/pitches.itely#newcode914
> Documentation/notation/pitches.itely:914: octotonicScale = 
> \relative c'
> { ees f fis gis a b c d }
> octatonicScale
Done

> http://codereview.appspot.com/4126042/diff/3009/ly/music-functions-init.ly#newcode467
> ly/music-functions-init.ly:467: (ly:music? ly:music? ly:music?)
> indent
Done

> http://codereview.appspot.com/4126042/diff/3009/ly/music-functions-init.ly#newcode475
> ly/music-functions-init.ly:475: (ly:music? ly:music? ly:music?
> ly:music?)
> indent
Done

> http://codereview.appspot.com/4126042/diff/3009/ly/music-functions-init.ly#newcode800
> ly/music-functions-init.ly:800: (ly:music?)
> indent
Done

> http://codereview.appspot.com/4126042/diff/3009/scm/modal-transforms.scm#newcode25
> scm/modal-transforms.scm:25: ;; Returns a transposer for the 
> specified
> scale
> "docstring"
>
> (same for all the other functions)
Done

> http://codereview.appspot.com/4126042/diff/3009/scm/modal-transforms.scm#newcode38
> scm/modal-transforms.scm:38: (ly:warning "Root pitch not in 
> scale!")
> none of the warnings follow coding style
>
> "root pitch not in scale"
>
> + need localizing: (_i "warning")
Done

> http://codereview.appspot.com/4126042/
for continuation see http://codereview.appspot.com/4079064/

Trevor