Re: Add Modal transformations (issue4126042)

[Trevor Daniels]

Changes in http://codereview.appspot.com/4079064/

From: <address@hidden>
Sent: Friday, February 04, 2011 1:43 AM
Subject: Re: Add Modal transformations (issue4126042)


> LGTM.  I don't think you need to wait until Sat.

Perhaps I should have waited :(

> http://codereview.appspot.com/4126042/diff/3009/Documentation/notation/pitches.itely#newcode840
> Documentation/notation/pitches.itely:840: A motif can be 
> transposed
> within a given scale with
> colon please:
Done

> http://codereview.appspot.com/4126042/diff/3009/Documentation/notation/pitches.itely#newcode903
> Documentation/notation/pitches.itely:903: note with
> Colon please:
Done

> http://codereview.appspot.com/4126042/diff/3009/Documentation/notation/pitches.itely#newcode933
> Documentation/notation/pitches.itely:933: A motif can be reversed 
> to
> produce its retrograde with
> ditto:
Done

> although in this case, I really don't think we need an @example. 
> I
> mean,
>   \retograde \music-expression
> is pretty clear.
Example deleted

> http://codereview.appspot.com/4126042/diff/3009/input/regression/modal-transforms.ly#newcode9
> input/regression/modal-transforms.ly:9: ges' aes' a' b'
> heh, I thought that after so many people reviewing it, there'd be
> nothing "substantial" left to comment on.
>
> missing duration:
>   ges'4
> :)
>
>
> oh wait, this is a regtest, not the docs.  ok, never mind, we're 
> not
> fussy about input code syntax here.
And it's a scale, so durations are superfluous.  I deleted
the first duration too.

> http://codereview.appspot.com/4126042/

For continuation see http://codereview.appspot.com/4079064/

Trevor