Re: Add Modal transformations (issue4126042)

[tdanielsmusic]

Thanks Keith


http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):

http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely#newcode867
Documentation/notation/pitches.itely:867: pentatonicScale = \relative c'
{ ges aes bes des ees ges }
On 2011/02/03 07:22:36, Keith wrote:

> Oops, you want only the first /five/ pitches.
Done

> If you like, you could simplify by basing the scale on f
>   \relative c' { f g a c d }
> \motif = \relative c' { d8 c f,4 <f' a,> <f a,> }

This was originally called blackNoteScale.  I think I prefer
to leave it as the black notes so the example retains its familiarity.

http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely#newcode943
Documentation/notation/pitches.itely:943: motif = \relative c' { c8.
ees16 fis8. a16 b8. gis16 f8. d16 }
On 2011/02/03 07:22:36, Keith wrote:

> Optionally, you could throw in a slur
Done.

http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely#newcode967
Documentation/notation/pitches.itely:967:
On 2011/02/03 07:22:36, Keith wrote:

> Optionally, a note that ties break, even though slurs
> work fine.  (Internally, ties are only attached to one
> note)
> @knownissues
> Manual ties inside @code{\retrograde} will be broken and
> generate warnings.  @ref{Automatic note splitting} can be
> enabled to generate some ties automatically.
Done

http://codereview.appspot.com/4126042/