Re: Add Modal transformations (issue4126042)

[tdanielsmusic]

Thanks James


http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):

http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely#newcode828
Documentation/notation/pitches.itely:828: Lilypond provides functions
for applying these transformations.
On 2011/02/03 10:14:47, pkx166h wrote:

> Do we need this last sentence 'Lilypond provides..'.

No.  Deleted.

http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely#newcode862
Documentation/notation/pitches.itely:862: @end lilypond
On 2011/02/03 10:14:47, pkx166h wrote:

> do we need the '\score' and/or '\new Staff' between the
> @Lilypond and @end Lilypond constructs?

Yes.  It's the same with \transpose.

http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely#newcode868
Documentation/notation/pitches.itely:868: motif = \relative c' { ees8
des ges,4 <ges' bes,> <ges bes,>}
On 2011/02/03 10:14:47, pkx166h wrote:

> need a space before the closing '}'
Done.

http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely#newcode912
Documentation/notation/pitches.itely:912: opposite direction:
On 2011/02/03 10:14:47, pkx166h wrote:

> I had to read this a few times for to make sense to me,
> so how about instead:
Done

http://codereview.appspot.com/4126042/diff/5002/Documentation/notation/pitches.itely#newcode953
Documentation/notation/pitches.itely:953: The combined operation of
inversion and retrograde produce the
On 2011/02/03 10:14:47, pkx166h wrote:

> The combined operation of @code{inversion} and
> @code{retrograde} ...
No.  These are not code items.  If anything they might be
@notation{}, but we don't do that for every musical term
every time it is used, only the first time in a section.

http://codereview.appspot.com/4126042/