Re: Add Modal transformations (issue4126042)

[Michael Ellis]

Hi Trevor,
Took me a couple of days longer to get to this than I planned.  Sorry
for the delay.  Zip of new versions attached.  Believe it addresses
all issues from rietveld.

-- All scheme functions now have docstrings.
-- All ly:warnings have (_i "warning text")
-- All module names begin with "modal-transforms"
-- \modalInversion now has 2 required pitch arguments per our discussions.

I've also made the argument naming consistent throughout the scheme
and music functions.

Transpose is now
\modalTranspose from to scale music

and inversion is now
\modalInversion around to scale music

so that
\displayLilyMusic \modalInversion e' f'  {c d e f g a b} { c'4 e' g' }

yields {a' f' d'},

i.e. modally inverted "around" e' and then modally transposed
so that e' moves "to"  f'.

Notice that modalInversion  has the argument order changed since our
last discussion  where were considering  "from  pivot" because as I
played with the functions I found it slightly confusing to mentally
map the outcome to the arguments.  I think the new names and order are
easier to think about (in English at least).  Hope this seems ok to
everyone.
Again, thanks for your encouragement and help!

Cheers,
Mike


On Sat, Feb 5, 2011 at 1:45 PM, Trevor Daniels <address@hidden> wrote:
>
> Michael Ellis wrote Saturday, February 05, 2011 4:23 PM
>
>> In practice, it will be more efficient to code it as Pal suggests,
>> with two index operations -- although I have no idea whether the
>> efficiency gain would be significant in terms of LilyPond's total
>> processing overhead.
>
> I'm not unhappy with that.  And you're right, the symmetry
> of the operations is then quite pleasing.
>
>> Daniel, what's the best way for me to submit the changes?  Does
>> codereview support a way to locally clone the current version. And
>> would you rather have a patch or a new copy?
>
> Trevor, actually :)
>
> You can download the patchset from Rietfeld using the
> "download raw patch set" button.  It should apply to
> any recent state of git.
>
> A patch against git with this download applied will be
> fine, as would a new copy of the changed files.
>
> Trevor
>
>
>

modal-transforms.zip
Description: Zip archive