lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

describing regression checking more explicitely (issue4621041)


From: lemniskata . bernoullego
Subject: describing regression checking more explicitely (issue4621041)
Date: Tue, 14 Jun 2011 21:40:37 +0000

Reviewers: Graham Percival, james.lowe_datacore.com,

Message:
A small change to the CG to make things more obvious for the beginners.
I hope that what i wrote is true ;)

Rewording suggestions are most welcome.


http://codereview.appspot.com/4621041/diff/1/Documentation/contributor/regressions.itexi
File Documentation/contributor/regressions.itexi (right):

http://codereview.appspot.com/4621041/diff/1/Documentation/contributor/regressions.itexi#newcode191
Documentation/contributor/regressions.itexi:191: Ensure that currently
built binary is the one without your changes.
I think a beginner can overlook this step.

http://codereview.appspot.com/4621041/diff/1/Documentation/contributor/regressions.itexi#newcode201
Documentation/contributor/regressions.itexi:201: in
@file{lilypond-git/build/} directory.
i remember that it wasn't obvious for me whether to run
make test-baseline
in lilypond-git/ or in lilypond-git/build/.

Description:
describing regression checking more explicitely

Please review this at http://codereview.appspot.com/4621041/

Affected files:
  M Documentation/contributor/regressions.itexi


Index: Documentation/contributor/regressions.itexi
diff --git a/Documentation/contributor/regressions.itexi b/Documentation/contributor/regressions.itexi index 3ec39d49cf201b83e7beaaa516a7e4bff66bf28d..50b038b71876356c4250987c817469e896cc1811 100644
--- a/Documentation/contributor/regressions.itexi
+++ b/Documentation/contributor/regressions.itexi
@@ -188,13 +188,18 @@ twice.
 @enumerate

 @item
-Before making changes, a baseline should be established by
-running:
+Ensure that currently built binary is the one without your changes.
+
address@hidden
+Before making changes to the code, establish a baseline for the
+comparison by running:

 @example
 make test-baseline
 @end example

+in @file{lilypond-git/build/} directory.
+
 @item
 Make your changes, or apply the patch(es) to consider.

@@ -212,7 +217,7 @@ After this has finished, a regression test comparison will be
 available at:

 @example
-out/test-results/index.html
+build/out/test-results/index.html
 @end example

 For each regression test that differs between the baseline and the





reply via email to

[Prev in Thread] Current Thread [Next in Thread]