lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: describing regression checking more explicitely (issue4621041)


From: percival . music . ca
Subject: Re: describing regression checking more explicitely (issue4621041)
Date: Wed, 15 Jun 2011 08:21:32 +0000


http://codereview.appspot.com/4621041/diff/5001/Documentation/contributor/regressions.itexi
File Documentation/contributor/regressions.itexi (right):

http://codereview.appspot.com/4621041/diff/5001/Documentation/contributor/regressions.itexi#newcode201
Documentation/contributor/regressions.itexi:201: @warning{
On 2011/06/15 08:14:54, Janek Warchol wrote:
Maybe it would be better placed at the bottom or over point 5?
Should this be an Advanced note?

move it to an advanced note at the bottom of the page.  It's certainly
not important enough to be a warning; we want to "save" those for truly
important stuff.

http://codereview.appspot.com/4621041/diff/5001/Documentation/contributor/regressions.itexi#newcode207
Documentation/contributor/regressions.itexi:207: @code{make} and
@code{make check} it (without doing @code{make test-baseline}
remove the parenthesis, just end with:
@code{make} and @code{make check} it without doing @code{make
test-baseline} again.

http://codereview.appspot.com/4621041/diff/5001/Documentation/contributor/regressions.itexi#newcode224
Documentation/contributor/regressions.itexi:224: available at:
available (relative to the current build/ directory) at:

http://codereview.appspot.com/4621041/diff/5001/Documentation/contributor/regressions.itexi#newcode227
Documentation/contributor/regressions.itexi:227:
lilypond-git/build/out/test-results/index.html
second thought: I think I prefer:
out/test-results/index.html

in order to not confuse people, see above comment.

http://codereview.appspot.com/4621041/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]