Re: Allows for rider grobs in outside-staff-priority. (issue4639075)

[address@hidden]

On Jul 14, 2011, at 2:47 PM, address@hidden wrote:

> 
> http://codereview.appspot.com/4639075/diff/18001/lily/axis-group-interface.cc#newcode670
> lily/axis-group-interface.cc:670:
> Axis_group_interface::has_outside_staff_parent (Grob *me)
> Why not make this part of the Grob class instead of the
> Axis_group_interface?  It seems to be a Grob operation, and so belongs
> there.
> 
> But I'm treading on thin ice here; my comments could be entirely wrong.
> 

I'm not sure either - you bring up a good question.  We'll see what other 
people have to say.

> http://codereview.appspot.com/4639075/diff/18001/lily/axis-group-interface.cc#newcode675
> lily/axis-group-interface.cc:675: || has_outside_staff_parent
> (me->get_parent (Y_AXIS)))
> Do you want one of these to be X_AXIS?  I can't see any reason to
> duplicate the Y_AXIS calls.


Oops...fixing and reposting the patch now.

Cheers,
MS