[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Creates a glissando stem grob that uses stems' functionality. (issue
From: |
address@hidden |
Subject: |
Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044) |
Date: |
Wed, 20 Jul 2011 22:04:38 +0200 |
On Jul 20, 2011, at 6:27 PM, address@hidden wrote:
>
> http://codereview.appspot.com/4777044/diff/7001/input/regression/glissando-stem.ly
> File input/regression/glissando-stem.ly (right):
>
> http://codereview.appspot.com/4777044/diff/7001/input/regression/glissando-stem.ly#newcode10
> input/regression/glissando-stem.ly:10: \xenakisStem #(ly:make-duration
> 3) #32
> This should be a music function, possibly incorporating the \glissando
> for the initial note.
>
> Something like this, perhaps:
>
> #(define-public (note-to-gliss-stem music)
> "Replace @code{NoteEvent}s and @code{SkipEvent}s by
> @code{GlissandoStemEvent}s."
> (if (or (music-has-type music 'skip-event)
> (music-has-type music 'note-event))
> (make-music 'GlissandoStemEvent
> 'origin (ly:music-property music 'origin)
> 'duration (ly:music-property music 'duration))
> music))
>
> xenakisStems =
> #(define-music-function (parser location music) (ly:music?)
> (music-map note-to-gliss-stem music))
>
> \relative c' {
> c4:32\glissando
> \xenakisStems {
> s8:32\f\> s s16 c s8:64
> }
> a''\p
> }
>
Great idea! Done.
> http://codereview.appspot.com/4777044/diff/7001/scm/define-grobs.scm
> File scm/define-grobs.scm (right):
>
> http://codereview.appspot.com/4777044/diff/7001/scm/define-grobs.scm#newcode960
> scm/define-grobs.scm:960: (duration . ,(grob::calc-property-by-copy
> 'duration-log))
> remove
>
Done (have no clue why that was in there...).
> http://codereview.appspot.com/4777044/diff/7001/scm/define-grobs.scm#newcode961
> scm/define-grobs.scm:961: (duration-log . ,(grob::calc-property-by-copy
> 'duration-log))
> ,stem::calc-duration-log
Done.
New patch set uploaded. The new patch has script support. I'll be tinkering
with beams in the next few days.
Cheers,
MS
- Creates a glissando stem grob that uses stems' functionality. (issue4777044), mtsolo, 2011/07/20
- Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044), n . puttock, 2011/07/20
- Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044),
address@hidden <=
- Music functions with pitch and duration arguments (was: Creates a glissando stem grob that uses stems' functionality. (issue4777044)), David Kastrup, 2011/07/21
- Re: Music functions with pitch and duration arguments (was: Creates a glissando stem grob that uses stems' functionality. (issue4777044)), Han-Wen Nienhuys, 2011/07/21
- Re: Music functions with pitch and duration arguments, David Kastrup, 2011/07/22
- Re: Music functions with pitch and duration arguments, Han-Wen Nienhuys, 2011/07/22
- Re: Music functions with pitch and duration arguments, David Kastrup, 2011/07/22
- Review music functions with pitch and duration arguments (was: Music functions with pitch and duration arguments), David Kastrup, 2011/07/22
- Re: Review music functions with pitch and duration arguments, David Kastrup, 2011/07/23
- Re: Review music functions with pitch and duration arguments, David Kastrup, 2011/07/24
- RE: Review music functions with pitch and duration arguments, James Lowe, 2011/07/24
- Re: Review music functions with pitch and duration arguments, David Kastrup, 2011/07/24