Re: Creates a Flag grob. (issue 4922042)

[mtsolo]

On 2011/08/22 12:52:05, hanwenn wrote:
> On Mon, Aug 22, 2011 at 7:20 AM, Mike Solomon <mailto:address@hidden>
wrote:

> >

http://codereview.appspot.com/4922042/diff/1/scm/define-grob-properties.scm#newcode276
> > scm/define-grob-properties.scm:276: (flag-style ,symbol? "A symbol
> > determining what style of flag
> > rename to style? Unfortunately, then we don't have any documentation
any
> > more about the valid values... :(
> >
> > You've hit the proverbial nail on its proverbial head. &nbsp;It is
for this
> > reason that I'm wary about renaming.

> Yes, but please rename anyway.  You could put the 'style values in the
> doc of flag-interface.


> --
> Han-Wen Nienhuys - mailto:address@hidden -
http://www.xs4all.nl/%7Ehanwen

Done.

Cheers,
MS

http://codereview.appspot.com/4922042/