[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Uses langdefs.py to create language list for create-weblinks-itexi.p
|
From: |
percival . music . ca |
|
Subject: |
Re: Uses langdefs.py to create language list for create-weblinks-itexi.py (issue 4951047) |
|
Date: |
Sat, 03 Sep 2011 09:28:45 +0000 |
On 2011/09/02 06:25:59, jan.nieuwenhuizen wrote:
If that works, then why not have
+import langdefs
+langs = [i.code if i.code != 'en' else '' for i in
langdefs.LANGUAGES]
I agree.
Phil, why did you push this patch without implementing this, or at least
responding to Jan to say why you thought it was a bad idea? I think
this is bad form; we want to encourage developers to review patches, but
if we ignore their suggestions that pretty much kills any incentive for
people to review stuff.
Please revert the patch and let's talk about Jan's suggestion.
http://codereview.appspot.com/4951047/