Re: Improves some parmesan noteheads. (issue 4639065)

[benko . pal]

there are problems: the patch as is fails the mensural-ligatures
regtest.  see below.

p


http://codereview.appspot.com/4639065/diff/13002/lily/mensural-ligature.cc
File lily/mensural-ligature.cc (right):

http://codereview.appspot.com/4639065/diff/13002/lily/mensural-ligature.cc#newcode147
lily/mensural-ligature.cc:147: Direction stem_dir = stem ?
get_grob_direction (stem) : CENTER;
this is unneeded: there are no stemmed notes within ligaturae.

http://codereview.appspot.com/4639065/diff/13002/lily/mensural-ligature.cc#newcode151
lily/mensural-ligature.cc:151: -1);
this is bad: shapes within ligaturae depend not only on duration but on
context as well.  in other words: MLP_BREVIS doesn't necessarily
correspond to duration -1, etc.
use note_shape instead of duration_log: turn MLP_BREVIS into "M1",
MLP_LONGA into "M2" and MLP_MAXIMA into "M3".

perhaps we may change the MLP macros in mensural-ligature.hh to be
simpler.

http://codereview.appspot.com/4639065/diff/13002/lily/mensural-ligature.cc#newcode160
lily/mensural-ligature.cc:160: + (duration_log == -3 ? "lig" : "") +
"mensural";
put all computations in lines 145-160 into the block in lines 172-183.

http://codereview.appspot.com/4639065/