Re: Rietveld workflow problems

[Janek Warchoł]

2011/9/21 Reinhold Kainhofer <address@hidden>:
> Am Wednesday, 21. September 2011, 15:04:05 schrieb David Kastrup:
>> Reinhold Kainhofer <address@hidden> writes:
>> > Am Wednesday, 21. September 2011, 10:52:37 schrieb David Kastrup:
>> >> Perhaps it would be nice if we found a way to play with "Gerrit",
>> >> supposedly a git-based system similar to Rietveld.
>> >
>> > I looked at gerrit a while ago. If you want to take a look at it:
>> > http://server.kainhofer.com:8088/
>> >
>> > Here is a quick summary:
>> >
>> > -) Each review is basically one commit in a branch on the gerrit server.
>>
>> Well, that's pretty much what we already have.
>
> No. In gerrit you really need to clean up your patches before you submit them
> for review. I typically have lots of small commits in a branch when I upload a
> patch to rietveld. git-cl will simply take the diff to origin/master (i.e. all
> patches in the branch combined into one large patch) and show the combined
> diff. gerrit, on the other hand, will show each small patch as one review.

+1, that's what i was going to write.

> So, I would have to clean up my local branch before submitting for review
> (i.e. rebase -i and squash and reorder the patches).

And do this each time when you're submitting a fix for that patch, did
i get it right?

I don't like this.

>> If one can't link
>> related reviews in a manner that you can, say, _pull_ a reviewed patch
>> (which should automagically fetch any dependencies), I am not all that
>> clear of what it actually gives us in addition.

What do you think about the branching solution i described?  Isn't it
working just like this?

cheers,
Janek