Re: Output from woodwind-diagrams-key-lists.ly

[Phil Holmes]

----- Original Message ----- 
From: "Keith OHara" <address@hidden>
To: <address@hidden>
Sent: Saturday, December 17, 2011 7:04 PM
Subject: Re: Output from woodwind-diagrams-key-lists.ly


> mike <at> apollinemike.com <mike <at> apollinemike.com> writes:
>
> > This regtest makes sure that the key-name function works for all
> > instruments - I'd be open to other options
>
> Just to be clear, Phil strongly suspects that the output is not checked,
> so if I accidentally broke the key-name function to print something wrong,
> nobody would notice (until somebody sees the mistake in the docs, and that
> path doesn't even use the regtest).
>
> I like David's redirection idea, sending to dev/null if the purpose is to
> exercise the key-name function, or to stderr if the purpose is to flag
> changed output.

Seconding this, it seems to me the best option is todo a small rewrite of 
display-woodwind-diagrams.scm so that either it defaults to sending output 
to stderr, or that there's an option to direct output to stdout, stderr, 
dev/null or whatever.  Unfortunately I've looked at the file and don't have 
a clue as to how to do this.  Can anyone else offer help?

> As it is, the regtest seems to give a false sense of security, so Phil's
> idea of removing it also seems very sensible.

Think that would be a fall-back if the option above can't be implemented. 
In practice, the regtest doesn't appear to test all instruments anyway - 
it's missing the tin whistle and some saxophones.  Fixing that would be a 
further improvement.

--
Phil Holmes