lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Changes to allow compiling with -Werror using gcc 4.6.2 on i386. (is


From: graham
Subject: Re: Changes to allow compiling with -Werror using gcc 4.6.2 on i386. (issue 5489092)
Date: Tue, 20 Dec 2011 01:54:29 +0000

wow, I'd love to enable -Werror!

You'll probably find a ton of more errors when running 'make check' --
apparently that compiles some stuff in flower/ that isn't compiled
during a normal make.


http://codereview.appspot.com/5489092/diff/1/lily/beaming-pattern.cc
File lily/beaming-pattern.cc (right):

http://codereview.appspot.com/5489092/diff/1/lily/beaming-pattern.cc#newcode187
lily/beaming-pattern.cc:187: I64 count = 1;  //default -- 1 base moments
in a beam
huh, I've never encountered I64 before... why does this particular int
need to be explicitly 64 bits?  If we really can't fit that data into 32
bits, it would be nice to add a comment explaining why.

http://codereview.appspot.com/5489092/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]